Re: Module status: Oledrion |
by skenow on 29/12/2022 16:32:07 That's because I just submitted it before the post |
Re: Module status: Oledrion |
by fiammybe on 28/12/2022 19:39:55 Sure, no problem. I hadn't seen your pr before. |
Re: Module status: Oledrion |
by skenow on 28/12/2022 19:20:14 @fiammybe - would you start with the pull request I just added? I applied the source formatting in our coding standards before making any other changes. It's so much simpler than trying to review that and the code changes that come later. |
Re: Module status: Oledrion |
by skenow on 28/12/2022 13:20:49 I think I had issues with the character set because of the move to MySQL 8 - it turned the generic utf8 to utf8mb3 |
Re: Module status: Oledrion |
by fiammybe on 28/12/2022 11:52:38 Hi Steve, thank you for this first batch of tests. I will already make the changes you mention on github. I'm currently focussing on getting ImpressCMS 1.5.0 ready for PHP8 so that has my focus at the moment, but getting oledrion running on ImpressCMS 1.5 would be nice indeed. You encounter issues because the comments were written in French, and they use these darn accents I think I will translate them. |