Forum : ImpressCMS

Fork me on GitHub


Subject:*
Name/Email:*
Message Icon:*
Message:*	SAMPLE [quote] skenow wrote: <p>There are quite a few more occurrences of $icmsModule throughout the core. In some cases, it is also being assigned, so it is a  valid use. Rather than go though all 240 instances, I'm focusing on the results I get with some key functions and modules.</p> <p>As of this point, I have tested these modules with the upcoming New 2.0 release</p> <ul> <li>imBlogging - minor updates necessary. Already committed to my repo</li> <li>imTagging - minor updates necessary. Already committed to my repo</li> <li>Content - working, once core data types handing was addressed</li> <li>iForum - not working. Needs a bit of an overhaul to deal with $icmsModule changes</li> <li>Profile - not working. Needs a bit of an overhaul to deal with $icmsModule changes</li> <li>Simplywiki - 2.0.0 RC does work (I just need to finish up the release - it's been out for a long time)</li> </ul> <p>Most of what remains is going to have to be done in the modules.</p> <p>PHPMailer is going to need an update, which I've got staged locally and doing  a basic test before committing. I'll put that in another PR.</p> <p>Here is the main pull request - <a href="https://github.com/ImpressCMS/impresscms/pull/1430">https://github.com/ImpressCMS/impresscms/pull/1430</a> - and my working branch - <a href="https://github.com/skenow/impresscms/tree/1.5.x-PHP7-strict">https://github.com/skenow/impresscms/tree/1.5.x-PHP7-strict</a></p> <p> </p><!-- filtered with htmlpurifier --><!-- input filtered -->[/quote] [more...]
Options:*	Enable html tags Enable Smiley Enable BB Code

Re: new 2.0 release

by fiammybe on 2023/5/28 10:38:38

I finally rectified my server setup, I broke it removing too much from the old site running there. Felt a bit like the Procession of Echternach to get here

But now I have a https domain working and the new version looks to run like it should, I haven't found any anomalies.

Re: new 2.0 release

by skenow on 2023/5/28 10:09:49

And today ...

No problem installing on the server. :smh:

Basic tests with the new version of PHPMailer succeeded, so I'll have another PR coming.

Re: new 2.0 release

by skenow on 2023/5/27 15:13:53

Site with problems during install: PHP 7.3.25

Site without problems during install: PHP 7.4.16

I don't think that's the problem - the PHP error log shows a parse error. PHP Parse error: syntax error, unexpected 'https' (T_STRING) in modules/system/admin/customtag/class/customtag.php(104) : eval()'d code on line 19

Why would that even be called during installation?

Re: new 2.0 release

by skenow on 2023/5/27 14:52:04

Yes, the latest in the 1.5.x branch is what I'm working with.

Odd, I tried on another server and it worked fine. Now to figure out what the differences between servers is so we can identify what is the issue.

Let me know what happens when you try.

Re: new 2.0 release

by fiammybe on 2023/5/27 13:17:23

I'll verify. Can you confirm that I need to checkout this version : https://github.com/ImpressCMS/impresscms/commit/79907e64fea77dc16ecf1cf49cfafba98b1c41d6 (the latest in the ImpressCMS 1.5 branch)

ImpressCMS is a multi-language content management system for the web. It is community-built, an open source project and based on the common web technologies of PHP and MySQL.

Useful Links

More information

Find us on Social Media