My initial tests were with PHP7.4. Testing with PHP8.0, there are some errors to overcome. I will be posting updates soon.
Do you think we could include in the upcoming 2.0 release?
I'm working on a responsive theme in Bootstrap 5, but that is still some way of, certainly if you want it to work nicely on mobile devices (more than 50% of web trafic nowadays) AND be flexible with the standard layout in iTheme.
My commitments were to get the release ready for review, and that has been completed, thanks to David and Raimondas.
All major hurdles have been cleared - complete install and upgrade (from 1.4.4) have been successful. There is an open pull request to merge in the update to PHPMailer. Once that is reviewed and merged, we can move ahead with the release.
I need to verify the GA4 changes have been merged - they aren't showing up in the branch yet
There are some things I would like to see added - a responsive theme, for one - but I'd rather get this out and work on some refinements afterwards.
As mentioned earlier, there are some updates to modules that will also need to be done to work with this release. I'll be posting PRs this week for the ones I have found.
For this week -
I finally rectified my server setup, I broke it removing too much from the old site running there. Felt a bit like the Procession of Echternach to get here
But now I have a https domain working and the new version looks to run like it should, I haven't found any anomalies.
And today ...
No problem installing on the server. :smh:
Basic tests with the new version of PHPMailer succeeded, so I'll have another PR coming.
Intermediary preview : I've been working on a Bootstrap 5 variant of the old iTheme, trying to stay as close to the original, but also taking into account what the web is expecting nowadays. I'm doing the design first in HTML, in order to convert it later into theme pages.
This is the current state of the design itself, I'm quite pleased with where I've gotten until now. Remarks and suggestions are always appreciated.
Source code is available on Github : https://github.com/fiammybe/impresscms-bs5-theme
Site with problems during install: PHP 7.3.25
Site without problems during install: PHP 7.4.16
I don't think that's the problem - the PHP error log shows a parse error. PHP Parse error: syntax error, unexpected 'https' (T_STRING) in modules/system/admin/customtag/class/customtag.php(104) : eval()'d code on line 19
Why would that even be called during installation?
Yes, the latest in the 1.5.x branch is what I'm working with.
Odd, I tried on another server and it worked fine. Now to figure out what the differences between servers is so we can identify what is the issue.
Let me know what happens when you try.
I'll verify. Can you confirm that I need to checkout this version : https://github.com/ImpressCMS/impresscms/commit/79907e64fea77dc16ecf1cf49cfafba98b1c41d6 (the latest in the ImpressCMS 1.5 branch)
In doing some more testing (updating PHPMailer to a PHP7/8-compliant version), I'm running into issues installing on https. Could someone else test and confirm?
Doing some testing before merging in changes and packaging everything up. Found something that needs to be addressed - a function call to a function that has been removed (icms_float). I should have something by the end of the day.
Once I can validate a fresh install, I'll check an upgrade before releasing.
I've reviewed the PR - could someone else have a look at it, too?
Remember when we were hosting our repositories on Assembla? They had a feature for standup reports, and I added recurring events to my calendar to update my standup reports twice a week - Wednesday evenings and Saturday mornings. Those reminders still come up. So - I will use those reminders to trigger updates for what I'm working on.
David also has a thread for what he's working on - we focus on different things, all of them are to keep some momentum going for ImpressCMS.
There's something I want to emphasize - the minimum PHP requirement for the upcoming 2.0 has been lowered to PHP 7.4. That does not mean it will not work on PHP 8. It just means we will not be introducing anything in this release that requires PHP 8 to function. I work with that in mind.
Because I do support sites with a variety of requirements, I do test a wide variety of actions and methods. So, the requirements have been expanded for functions provided and governed by the core, regardless of PHP version.
I will be looking to have my pending changes merged to the release branch by Wednesday, and adding an update for some external libraries (PHPMailer among them). Support for Google Analytics 4 will also be part of this release.
Onward and Upward!
Thank you, David! I'm looking forward to some new themes - it's not an area I'm very gifted in. I've learned that if we cannot meet our family needs, we aren't going to be of much value anywhere else, either. Take care!
I have been very quiet these last months on the ImpressCMS side of things.
@skenow has taken over the release of the newly-minted 2.0, as he has most requirements for supporting legacy sites and sites coming from old versions of ImpressCMS. It sometimes looks like lowering the version requirement from PHP 7.4 has opened up quite a few issues, which means the 2.0 release is advancing slower than I had anticipated when it was still called 1.5.
Personally I took a break from the development side of things these last few months. A heavily charged family calender reduced my available time to such an extent that I couldn't spend a minimum amount of development time per week required to see any significant progress, so I changed my focus to working on some base themes for ImpressCMS.
I am currently working on basic start themes based on both Bootstrap 5 and Bulma, 2 design frameworks that I have been using elsewhere. The idea is to have a base theme ready as soon as possible, in order to redevelop the standard ImpressCMS theme based on the bootstrap5 base theme.
Working with themes requires smaller chunks of available time to come up with something, so it is more motivating for me to work on that currently.
I'm now working out the different templates for multiple pages in the standard CMS setup. The goal is to have templates for as many modules as possible
As @fiammybe started in this thread, it's time for me to be transparent, accountable, and contribute more to the momentum of ImpressCMS than I have in recent times. This is my commitment to getting stuff done.
David (@fiammybe) and Raimondas (@MekDrop) have been the key contributors to maintaining our current releases and shaping our new major revamp of the core - and I want to thank them for stepping into this and getting a lot of the groundwork completed.
I can't speak for them, or even for you - only myself. I don't just do this for myself, though - it was always done to help the community of users. I have clients that depend on me to provide a solid website for them. However, they are not my primary source of income, so I divide my time.
I can't always control outcomes, but I do have a lot of influence over inputs and actions.
Here's my first list of actions I will take:
As I mentioned above, I don't just do this for myself. I do have motivations to do this, regardless. Having feedback is definitely going to help me stay focused and provide some energy to get things done. Less feedback and participation will probably mean that it will only take a bit longer, that's all.
Thanks to all who have participated and contributed to getting ImpressCMS this far!
There's still more before we're clear - need to adjust icms/ipf/About.php
I just installed Madfish's News module to test based on this thread and found another spot in the core to adjust. I've committed the fix and it's in my pull request.
There are quite a few more occurrences of $icmsModule throughout the core. In some cases, it is also being assigned, so it is a valid use. Rather than go though all 240 instances, I'm focusing on the results I get with some key functions and modules.
As of this point, I have tested these modules with the upcoming New 2.0 release
Most of what remains is going to have to be done in the modules.
PHPMailer is going to need an update, which I've got staged locally and doing a basic test before committing. I'll put that in another PR.
Here is the main pull request - https://github.com/ImpressCMS/impresscms/pull/1430 - and my working branch - https://github.com/skenow/impresscms/tree/1.5.x-PHP7-strict