iForum

Re: Moving on from Google Universal Analytics

Small update on this : this patch is released in the 1.4.5 version which, essentially, applies the patch on top of 1.4.4

See the release announcement:

Topic | Forum


iTheme 2.0 on Bootstrap 5

I started some time ago to recreate a bootstrap 5 theme that looks similar to the venerable iTheme for way past. I'm not there yet, but the homepage is already starting to look acceptable. Have a look at https://www.impresscms.eu/?theme_select=icms-b5

 

Topic | Forum


Re: Moving on from Google Universal Analytics

Here's a patch, if anyone wants to implement this and already haven't found a way to do it. I've bundled the files for both v1.3.11 and v1.4.4 into a single file.

There are 2 files to be concerned with - /libraries/icms/view/theme/Object.php and /plugins/preloads/googleanalytics.php. Make a backup of the first and replace with the file from the package for your version. Add the 2nd to the preloads folder.

Without any other changes, you should still be gathering data with the Universal Analytics tag. To us the new GA4 tag, you'll need to create a new property in Google Analytics to get your new tag. When you have it, update the value in your admin control panel of your site - Admin / Preferences / Meta + Footer. When you put in the new tag, include G- with the value. This is how ImpressCMS will know whether to use the UA version or the GA4 version.


Attach file:

zip GA4.zip Size: 19.22 KB; Hits: 55


Re: Standup Reports

PRs to the next release

  • HTMLPurifier - waiting  merged
  • WideImage - ready to request PR (without complete image editor fix) PR submitted
  • Fatal errors in session handler (improper type returned) - fix known (method updates to return boolean) PR submitted and merged
  • Fatal errors in Protector IP check (string v. integer) - merged

The Google Analytics update for GA4 is waiting on some minor changes, then it can be merged, too. We may even want to release a patch, since there are only days left before Google automatically changes



Re: Standup Reports

Just about. If our goal is for this release to run on PHP8, there are a few things that need to be addressed. If PHP7.4 is acceptable, then we are ready for another RC release.

The PR to update HTMLPurifier to work with PHP8 is waiting for review. Once that is merged, there aren't any fatal errors that I know of (one that I cannot reproduce during install, but occurs for another tester on Windows. We have a fix for that).

There is one thing that does not work on PHP8 - the image editor is the one I am  struggling with. It does work on PHP7.4, though. Mozilla's debug console says there is a missing semicolon in the javascript. But, only in PHP8+. So, something is being passed as an argument to the js functions that isn't properly formatted.

I'll fix the few other things I know about and leave the image editor for another time. More testers and eyes on the issue will help.

PRs to the next release

  • HTMLPurifier - waiting
  • WideImage - ready to request PR (without complete image editor fix)
  • Fatal errors in session handler (improper type returned) - fix known (method updates to return boolean)
  • Fatal errors in Protector IP check (string v. integer)

 



Re: Standup Reports

Would this be an appropriate time to release another RC?



Re: Standup Reports

I continued to test WideImage and the image editor.

Basis for further testing -

  • Used the latest release from github/smottt/WideImage (1.1.4)
  • Since it uses PSR-0, the icms autoloader works, and no specific includes or preloads are necessary

Initially I found that everything worked with the new WideImage library on ICMS 1.4.4 (max PHP is 7.4), but not in ICMS 2.0 with PHP 7.4. As it turns out, it was a preload method that was empty (icms_BootstrapEventHandler::backwardCompatibility). Adding a return value got it working on the 2.0.0RC branch (1.5.x) and PHP 7.4.

End result - all the functions work when using PHP 7.4. Switching to PHP 8.x results in failures when using the editor, whether it's crop, resize, or filter. Now, to figure out the PHP 8 issues.

It may, or may not, be something with the WideImage library. It may, or may not, be something with the image editor library. It may, or may not, be something with the core (the last issue was).

Another colleague has been helping me with this, as he now has some additional discretionary time. Hopefully, we'll figure this out soon.

 

 

 



Re: Standup Reports

HTMLPurifier has been updated successfully. Now on to WideImage. Viewing, adding, duplicating, and deleting are all working as expected. Editing (resize, crop, filter) all need some work. I’m not sure if it’s WideImage or the image-editor library. 



Re: Standup Reports

I've made some changes to be able to get things working - mostly - on PHP8.2. The latest issue is the version of HTMLPurifier. There is a version that is PHP8 compliant and I've begun testing with that. There are some changes to how things get loaded that are different, so it will take a bit of effort. If you disable HTMLPurifier (not recommended if users are allowed to post), the core appears fully functional on PHP 8.2.



Re: Bootstrap 5 variant of iTheme in the works

That would be too soon.

I'm still working out how to make all those columns work in a responsive manner, in a way that works for most scenarios. I think it will take at least a month to get something ready for distribution.



Re: Standup Reports

My initial tests were with PHP7.4. Testing with PHP8.0, there are some errors to overcome. I will be posting updates soon.



Re: Bootstrap 5 variant of iTheme in the works

Do you think we could include in the upcoming 2.0 release?



Re: Standup Reports

I'm working on a responsive theme in Bootstrap 5, but that is still some way of, certainly if you want it to work nicely on mobile devices (more than 50% of web trafic nowadays) AND be flexible with the standard layout in iTheme.



Re: Standup Reports

My commitments were to get the release ready for review, and that has been completed, thanks to David and Raimondas.

All major hurdles have been cleared - complete install and upgrade (from 1.4.4) have been successful. There is an open pull request to merge in the update to PHPMailer. Once that is reviewed and merged, we can move ahead with the release.

I need to verify the GA4 changes have been merged - they aren't showing up in the branch yet

There are some things I would like to see added - a responsive theme, for one - but I'd rather get this out and work on some refinements afterwards.

As mentioned earlier, there are some updates to modules that will also need to be done to work with this release. I'll be posting PRs this week for the ones I have found.

For this week -

  • Outline steps to upgrade: there are things that will need to be completed before uploading the upgrade files
  • Updates to modules identified needing changes to work in this version
  • Package release once it passes review



Re: new 2.0 release

I finally rectified my server setup, I broke it removing too much from the old site running there. Felt a bit like the Procession of Echternach to get here

 

But now I have a https domain working and the new version looks to run like it should, I haven't found any anomalies.

 



Re: new 2.0 release

And today ...

No problem installing on the server. :smh:

Basic tests with the new version of PHPMailer succeeded, so I'll have another PR coming.



Bootstrap 5 variant of iTheme in the works

Intermediary preview : I've been working on a Bootstrap 5 variant of the old iTheme, trying to stay as close to the original, but also taking into account what the web is expecting nowadays. I'm doing the design first in HTML, in order to convert it later into theme pages.

This is the current state of the design itself, I'm quite pleased with where I've gotten until now. Remarks and suggestions are always appreciated.

Source code is available on Github : https://github.com/fiammybe/impresscms-bs5-theme


Attach file:


png  impresscms-bootstrap5-itheme-draft.png (899.61 KB)
1102__312356473660a96d2d.png 1665X1819 px


Re: new 2.0 release

Site with problems during install: PHP 7.3.25

Site without problems during install: PHP 7.4.16

I don't think that's the problem - the PHP error log shows a parse error. PHP Parse error:  syntax error, unexpected 'https' (T_STRING) in modules/system/admin/customtag/class/customtag.php(104) : eval()'d code on line 19

Why would that even be called during installation?



Re: new 2.0 release

Yes, the latest in the 1.5.x branch is what I'm working with.

Odd, I tried on another server and it worked fine. Now to figure out what the differences between servers is so we can identify what is the issue.

Let me know what happens when you try.



Re: new 2.0 release

I'll verify. Can you confirm that I need to checkout this version : https://github.com/ImpressCMS/impresscms/commit/79907e64fea77dc16ecf1cf49cfafba98b1c41d6 (the latest in the ImpressCMS 1.5 branch)