iForum

Re: Where does the core inject all this javascript?

From a new post in an old topic - https://www.impresscms.org/modules/iforum/viewtopic.php?post_id=50656#forumpost50656

Wondering about the options below

Steve Twitter: @skenow Facebook: Steve Kenow

Topic | Forum


Re: default comments, notifications and permission setting ?

At this point, the default is to allow all comments if the module has comments (in icms_version.php). Probably since the base assumption is that ImpressCMS and predecessor were community sites and that would be the most common choice.

Also, all notifications defined in icms_version.php will be enabled by default.

Neither of these are reading anything from the module at the time of install.

However - you could override those options after the module is installed with the install function for the module, which is called at the very end of the process.

Steve Twitter: @skenow Facebook: Steve Kenow

Topic | Forum


default comments, notifications and permission setting ?

How do i disable comments and notifications as default setting of a module preferences

and also set default permission of module when installing the module

 

is this possible? any example i can refer to ?  



Re: Where does the core inject all this javascript?

As a side note, this thread does not show paragraph tags when I post something new. Strange



Re: Where does the core inject all this javascript?

Those issues are the same ones that I encountered during my tests. After that, I was investigating webpack, and there you can include files with a specific directive, and it tells webpack to make it a relative path.

Perhaps this kind of functionality should be left to the front-end developers and not taken on by the CMS?



Re: ImpressCMS site improvements for mobile

A very good question. And it looks like it is only posts that have been made after the migration to ImpressCMS 1.4.0.



Re: ImpressCMS site improvements for mobile

Why are the html tags showing in the rendered posts, now?

 


Attach file:


png  icms-forum-html-tags-rendered.png (80.25 KB)
54__52725e324badd513b.png 695X569 px

Steve Twitter: @skenow Facebook: Steve Kenow



Re: Where does the core inject all this javascript?

There are minify and combine functions in the core - and currently left unused. Mostly because the resulting file was placed in the cache/ folder and at least one of the js and css files had some specific paths that didn't work when the file was in a different location.

Steve Twitter: @skenow Facebook: Steve Kenow



Re: Where does the core inject all this javascript?

I found the locations in the header file where all the different files were loaded, and I included a switch statement so that I can switch the way includes are done by simply defining a boolean in the theme. When the boolean is true, I include a file 'combined.js' and 'combined.css', which are combined and minified versions of the different javascript and CSS files that are included at the moment. Whent he boolean is false, the old behaviour is still there.

This reduces considerably the loading time (first time at least) of a page. I still have some small issues with the minifying, but I think I have identified the problem.



Re: ImpressCMS site improvements for mobile

I ran into something else - I had to update the system module to regenerate templates.

Steve Twitter: @skenow Facebook: Steve Kenow



Re: Where does the core inject all this javascript?

icms_core_theme_Object does all the work, but the work to be done is defined in /header.php. Just search for ->addScript and ->addStylesheet

include/cp_functions:: icms_cp_header() creates the work for the admin area.

 

Steve Twitter: @skenow Facebook: Steve Kenow



Re: Where does the core inject all this javascript?

The billboard module needs major updates and it is no longer used on the site at the moment.

I'll look into the icms_view_theme_Object, because I want to understand where the different javascript and CSS files get included in the core. I believe some of them are not needed on every page. 



Re: ImpressCMS site improvements for mobile

<p>I tested on the test website before pushing the new code to the production website, but didn't verify after that. Noted for the future.</p>



Re: ImpressCMS site improvements for mobile

We're back in business - I deleted the contents of cache/ and templates_c/ and that resolved the issue.

Steve Twitter: @skenow Facebook: Steve Kenow



Re: ImpressCMS site improvements for mobile

I'm not sure what happened, but since this update, I am not able to access the admin area - I just get a blank page.

Edit: just added this and saved. The HTML tags go away on the save, since the forum setting has changed.

Steve Twitter: @skenow Facebook: Steve Kenow



Re: Where does the core inject all this javascript?

This is the question I had in the slack channel - "async deferred" can be used to move when the javascript is loaded. The actual place is during the renderMetas method of icms_view_theme_Object.

This works for most things and I have it running this way on several sites. The Billboard module does not work properly on the initial page load and renders separate images for each slide until you refresh (works sometimes)

Steve Twitter: @skenow Facebook: Steve Kenow



Re: Where does the core inject all this javascript?

These comes from <{$icms_module_header}> variable in theme. Sadly, right now I think there is no way to specify place where to output this variable.



Where does the core inject all this javascript?

I'm trying to find out where the core automatically injects javascript in my page. I use Bootstrap theme, and I came to the conclusion that I have 2 jquery scripts, and a load of other scripts as well that are included automatically on my page. Google proposes to change the place on the page, in order to speed the rendering, so I would like to know where the core does that, and perhaps alter the behaviour.



Re: ImpressCMS site improvements for mobile

I have fixed the most important issue : the topbar menu is now visible on small mobile devices, and the 'fork me on github' banner is no longer shown on those screen sizes. I'm looking at the blocks on the front page with news items and forum topics now to improve upon.



ImpressCMS site improvements for mobile

Hi, 

I've come to realize that the current theme has some issues for mobile admin users. The user menu block is not visible for mobile devices. The theme will be updated to improve on that. 

If you have other suggestions to improve the mobile experience, let me know in the thread.