Re: Impresstheme
- 2008/2/29 12:12:38
- web-M
I think it's nice :bravo:
Maybe the links can be added in the adminsection also?
web-M Personal website
Re: Impresstheme
- 2008/2/29 11:54:27
- marcan
Steve said:
Quote:
Now, based on suggestions for marketing, could we make a slight addition to the theme?
The globalnav div is currently empty, but could hold several links to ImpressCMS
Excellent suggestion, I just added this to the impresstheme and committed it in the impresscms_1.0 branch. I have also updated this very site so yo can simply select the impresstheme from the left column and see what it looks like.
Let me know !
Re: Impresstheme
- 2008/2/29 4:59:41
- skenow
Add it to the release notes or readme already in the package
Quote:
davidl2 wrote:
I think a simple readme text file to explain this would be a good idea.
Re: Impresstheme
- 2008/2/29 4:58:46
- skenow
Quote:
McDonald wrote:
Is it maybe an idea to inform users about these settings in theme.html in the install.html or in a document about setting up the impresstheme?
This way it is documented for new/other users and to avoid more confusion.
I think we can do that
I've been waiting for a final version of the theme to get started on [[Theme Structure]] in the wiki.This link could be added to the welcome block being discussed...
Re: Impresstheme
- 2008/2/29 4:58:35
- davidl2
I think a simple readme text file to explain this would be a good idea.
Re: Impresstheme
- 2008/2/29 4:48:46
- McDonald
Hello Marcan,
Just downloaded & installed impresscms_1.0-20080229.tar.tar to check the theme.
So far I can see everything is working normal.
The only setting I had to made was in theme.html:
Is it maybe an idea to inform users about these settings in theme.html in the install.html or in a document about setting up the impresstheme?
This way it is documented for new/other users and to avoid more confusion.
Many thanks!
Can't wait until Sunday....
Re: Impresstheme
- 2008/2/28 17:32:57
- marcan
Ok, about this:
Quote:
Ah, if I set theme_top_order to lrc in theme.html the 3 blocks are placed correctly without deleting the mentioned part from layout.css!!
Can you confirm that there is actually nothing to change in impresstheme as theme_top_order is already defined as lrc:
As for this:
Quote:
Don't forget to put the 2 lines for Lists in a stylesheet for the final version otherwise the problem with right column blocks will exist.
I just added this to impresstheme/style.css at line 100:
Committed in revision 1027 in branches/impresscms_1.0 branch.
I have also updated this very site (community.impresscms.org to the latest revision, so if you select the impresstheme in the left column theme block, you would be experiencing the very latest version.
I have also forced a nightly build to ease the life of anyone who would like to test the latest package:
http://www.impresscms.org/nightly/builds/1.0/impresscms_1.0-20080228.tar.gz
The only problem I see in the theme are with the redirect and close site templates, which I believe Snow is working on.
Let me know !
Re: Impresstheme
- 2008/2/28 17:30:15
- skenow
Now, based on suggestions for marketing, could we make a slight addition to the theme?
The globalnav div is currently empty, but could hold several links to ImpressCMS
Re: Impresstheme
- 2008/2/28 17:08:24
- McDonald
I've never made any changes to theme.html.
On my testsite only the following 3 blocks for the center column are defined:
- center block
- center bottom block 1
- center bottom block 2
The center block is placed alright, but the 2 center bottom blocks are suddenly displayed as left center bottom blocks.
...
Ah, if I set theme_top_order to lrc in theme.html the 3 blocks are placed correctly without deleting the mentioned part from layout.css!!
Never heard about this setting in theme.html before.
Might be a good idea to point users at this setting in theme.html.
Don't forget to put the 2 lines for Lists in a stylesheet for the final version otherwise the problem with right column blocks will exist.
Re: Impresstheme
- 2008/2/28 16:27:54
- skenow
Are you sure the display of the center block layout is incorrect? This theme has several options for center block display
Re: Impresstheme
- 2008/2/28 16:06:57
- McDonald
So far I'm only able to fix the problem in the center column by removing this part from layout.css:
I am still looking what is causing the problem with the right column.
EDIT
The problem with right column is caused by the following 2 lines:
These 2 lines are missing. I've added these lines to style.css and the right column blocks look alright now.
Re: Impresstheme
- 2008/2/28 15:57:19
- marcan
Ok good, were you able to spot the problem and fix this ?
Thanks !
Re: Impresstheme
- 2008/2/28 14:51:58
- McDonald
Sorry Marcan for all the confusion.
Indeed I downloaded that nighly build, but forgot to unzip it and used another version for testing.
So, now I unzipped the nightly build and overwrote the files again.
Now, the result is as follows:
- The content of the right blocks seem to have left/right margins set too wide
- The 2 bottom center blocks ar placed in the center column as left bottom blocks.
- Again no visible date in xhld module blocks in right column.
Re: Impresstheme
- 2008/2/28 14:35:55
- marcan
Hi McDonald, thanks for this... However, again, we do not have this file int he latest code : /impresstheme/css/style.css
Now, I am a bit confused, because you are saying you are downloading impresscms_1.0-20080228.tar.gz, which I assume you took from the Nightly Builds. If this is the case, then you downloaded this specific file. I just did the same to be sure. And this is indeed the latest code from the 1.0 branch, and there is no /impresstheme/css/style.css. See screenshot attached.
So I'm not sure what files you are testing.
Could you test the latest actual release ? No files have changed in the 1.0 branch since this R 2 release.
Let me know ! And thanks for your efforts. And if you see something we could improve to avoid this confusion, please tell me.
Thanks !
Re: Impresstheme
- 2008/2/28 13:10:38
- McDonald
Downloaded impresscms_1.0-20080228.tar.gz, removed all themes from my localserver installation and overwrote all files except mainfile.php with the new ones.
Updated the System module and removed all files from template_c.
Now I had problems with the bottom-center-blocks overlapping all 3 columns, see picture below:
In the right column I got blocks from GIJOE's xhld module and a block from WF-Links. In the WF-Links block the dates are visible but not in the xhld blocks.
I've changed the following lines in /impresstheme/css/style.css:
into
With the above applied changes everything seems to be alright (until further notice
)Hopefully others can confirm the above ... before Sunday.
Tested with IE7 only.
Re: Impresstheme
- 2008/2/28 8:14:17
- marcan
No problem,
Let us know as soon as you can if you are experiencing any problem with the theme. Final is Sunday
Thanks !
Re: Impresstheme
- 2008/2/28 7:35:57
- McDonald
Quote:
marcan wrote,
Problem is that in the new impresstheme, there is no css/style.css...
Wooops, I am mixing up the different releases.
Will come back to this subject asap.
Re: Impresstheme
- 2008/2/27 4:24:59
- marcan
Guys, perhaps there is something not understood correctly...
McDonald said:
Quote:
Oke above mentioned problems are solved. Here's my corrected version of /impresstheme/css/style.css :
Problem is that in the new impresstheme, there is no css/style.css...
What version you guys downloaded ?
As you can see here, Ihave replaced the theme from RC 1 with the new theme posted by Ana. The structure is different and there is no more css/ folder...
Could you test again the real RC 2 so we can be sure it's correct or not.
And also find out how you got yourself with the wrong theme. If it is a problem in our process we need to know it in order to fix it.
Thanks !
ImpressCMS is a multi-language content management system for the web. It is community-built, an open source project and based on the common web technologies of PHP and MySQL.
More information
