Quote:
core.php
Line 20-22
Can't be Bytes above and on this lines to be b, eg, Kb, Mb and so on
should be KB, MB, GB, TB, PB and so on.
by Vaughan on 2012/8/9 22:54:46
WARNING: this might cause a little debate
I do not agree with ID instead of id.
conventions say camelCase, or 2 letter acronyms should be uppercase like DB = database
but id is NOT an acronym. it is an abbreviation. therefore id or Id should be used.
WARNING: this might cause a little debate
I do not agree with ID instead of id.
conventions say camelCase, or 2 letter acronyms should be uppercase like DB = database
but id is NOT an acronym. it is an abbreviation. therefore id or Id should be used.
Who allowed the creation of 2 French teams ?
Pick one and remove the second, I know that XOOPers loves anarchy, but not move it and here please!
Order, Position... anything but Weight, yack
Quote:
ep98 wrote:
Order is for sorting (got experience, a lot of with all OS CMS released today)
When there is
Category A Position 3 []
Category B Position 5 []
Category C Position 1 []
(Save) Order is used for reordering them, by manually adding the new numbers.
Or should be added in on time of changes, one section in changelog languages for 1.3.3 Beta 2 or RC, for the current BETA there is no need, since all files will be re-uploaded when someone of the dev team take care of the empty spaces.
I'll see if I can make a diff between the 1.3.2 release and the 1.3 branch. That should identify the changed files
Modules
Banners
modinfo.php
Remove invalid spaces, convert to UTF-8
admin.php
Remove invalid spaces, convert to UTF-8
common.php
Remove invalid spaces, convert to UTF-8
main.php
Remove invalid spaces, convert to UTF-8
------------------------------------------
Content
modinfo.php
Line 18 Contents ?
Articles ? What's this contents.
Line 26 - Groups allowed to add content - not contents
Line 28 - 29 - not contents for sure
Even for static content, adding single page containing one line is article.
Remove invalid spaces, convert to UTF-8
admin.php
Line 22 Contents ?
Line 30 clone this content - Clone content/article
Remove invalid spaces, convert to UTF-8
blocks.php
Line 18
Show author and published info ?
Show author and publication info maybe ?
common.php
Line 18 (wow, favorite number) Poster - no such thing as Poster, it's Author
Line 22 and xx
Content body is Full content, Content Scoop is Content Intro.
Line 30 Published date
Published
Line 32 Updated date
Updated
Line 34 - Weight... there is no Weight (ohh it was Spoon) Neo
Line 49 All contents of %1
All articles from %1
Line 50 - %1 comments, and what about if is %1 comment ?
Remove invalid spaces, convert to UTF-8
main.php
Remove invalid spaces, convert to UTF-8
profile
modinfo.php
Remove invalid spaces, convert to UTF-8
admin.php
Remove invalid spaces, convert to UTF-8
blocks.php
Remove invalid spaces, convert to UTF-8
common.php
Weight again
Remove invalid spaces, convert to UTF-8
main.php
Remove invalid spaces, convert to UTF-8
(hmm in both cores, if the user comment a story published by another author, there is no link in the profile page with those comments)
system and it's sub-folder
Remove invalid spaces, convert to UTF-8
(Global corrections)
1. Weight - everything else, but not and this misleading crap
2. Id to ID
3. Content (except module name) should be Article and Articles.
Now back to previous question - which language files are changed ?
Edit: No matter what's changed, for next beta/RC will be important, anyway u have to change all language files.
ImpressCMS 1.3.3 Beta English language files:
/language/english
notification.php
No suggested changed, except remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
moduleabout.php
No suggested changed, except remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
misc.php
Convert it to UTF-8 or UTF-8 without BOM
mail.php
No suggested changed, except remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
global.php
Line 5 present from XOOPS 1.3 and no longer is used as feature in any XOOPS 2.x cores
define('_FETCHING','Loading...');
Line 30-31
define( '_XOBJ_ERR_REQUIRED', '%s is required' );
define( '_XOBJ_ERR_SHORTERTHAN', '%s must be shorter than %d characters.' );
(someone without work playing with formatting) - correct it.
Line 248-249
define( "_TRUST_PATH_HELP", "Warning: System failed in reaching Trust path.<br />The trust path is a folder where ImpressCMS and its modules will store some sensible code and information for more security.<br />It is recommended that this folder be outside of the web root, making it not accessible by a browser.<br /><a target='_blank' href='http://wiki.impresscms.org/index.php?title=Trust_Path'>Click here to learn more about the Trust path and how to Create it.</a>" );
define( "_PROTECTOR_NOT_FOUND", "Warning: System is unable to find if Protector is installed or active in your site.<br />We highly recommend you to install or activate Protector to improve your site's security.<br />We also have to thank GIJOE for this very good module.<br /><a target='_blank' href='http://wiki.impresscms.org/index.php?title=Protector'>Click here to learn more about Protector.</a><br /><a target='_blank' href='http://xoops.peak.ne.jp/modules/mydownloads/singlefile.php?lid=105&cid=1'>Click here to download the latest version of Protector.</a>" );
(again someone without work, to play with formatting)
except mentioned changes, remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
findusers.php
line 29-31
AIM/ICQ are the same thing and no one uses them, wont mention YIM, add FB/Skype instead
except mentioned changes, remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
error.php
No suggested changed, except remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
databaseupdater.php
line 41
define( '_DATABASEUPDATER_MSG_FROM_112', "<code><h3>You have updated your site from ImpressCMS 1.1.x to ImpressCMS 1.2 so you <strong>must install the new Content module</strong> to update the core content manager. You will be redirected to the installation process in 20 seconds. If this does not happen click <a href='" . ICMS_URL . "/modules/system/admin.php?fct=modulesadmin&op=install&module=content&from_112=1'>here</a>.</h3></code>" );
(formatting in Word, not here)
except mentioned changes, remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
countries.php
No suggested changed, except remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
core.php
Line 20-22
Can't be Bytes above and on this lines to be b, eg, Kb, Mb and so on
should be KB, MB, GB, TB, PB and so on.
Line 33 - for developer can be understandable, but for me the poor user this means nothing
define('_CORE_CLASSNOTINSTANIATED', 'This class cannot be instantiated!');
Translate it in human readable string.
except mentioned changes, remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
comment.php
No suggested changed, except remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
captcha.php
define("ICMS_CAPTCHA_RULE_TEXT", "Input the result from the expression");
Something readable by human ?
except mentioned changes, remove invalid intervals.
Convert it to UTF-8 or UTF-8 without BOM
calendar.php
define("_CAL_TGL1STD", "Toggle first day of week");
Select first day of the week maybe ?
in some areas is used 24 hours format, what should be done with those
Order is for sorting (got experience, a lot of with all OS CMS released today)
When there is
Category A Position 3 []
Category B Position 5 []
Category C Position 1 []
(Save) Order is used for reordering them, by manually adding the new numbers.
(due some requirements, which now I'm fighting with XOOPS.org, TX got some changes in the PHP Define statement)
Files containing such definitions
or maybe 'order'.
Native English speakers, what do you think?
at first sight - everywhere in the core
Weight must replaced with Position
that falls under the improvement of the quality I think. Having a better choice of words would be great, thank you!
Quote:
In the short term no major changes in the language system are planned, so let's focus on what can be done on the other points.
These are things I see that fall into this category:
* Make sure all language files are in UTF-8
* standardise language names
* improve the linguistic quality of the content
* eliminate duplicates and minimize contents
* investigate if the number of language files can be reduced
Okay, many topics here (and a few rants as well)...
let's focus on how we can improve the translation flow one thing at a time, starting with the 'low-hanging fruit' : the things that are not much work to do, but that will result in big improvements.
In the short term no major changes in the language system are planned, so let's focus on what can be done on the other points.
These are things I see that fall into this category:
* Make sure all language files are in UTF-8
* standardise language names
* improve the linguistic quality of the content
* eliminate duplicates and minimize contents
* investigate if the number of language files can be reduced
Quote:
Point 1 : a no-brainer,and it should be done. Using transifex can be a solution in the end, as it will output files that are in the correct character encoding. We will need to get more people using transifex for this (module maintainers).
* make sure translations are in UTF-8 for ALL languages (even en-uk)
This can be done simply by defining a standard list of languages according to international standards (en-us, en-gb). Question is, where do you stop? For now the en-gb and en-us are the same, and I don't see a reason why someone would want to create (and maintain!) both of them separately for most modules.
Reduce the number of fields : We do need to look into reduciing the duplicate content. That's a tricky one, because some text strings can be exactly the same in two contexts in English
Unless someone jumps in to abstract the entire language layer, and make it easy to switch between the two, I don't think this will be coming in the next few months, as the other systems don't have any added functionality to the module developer/end-user.
if those bloody american's didn't keep changing the spelling of English words, removing letters or changing letters all the time, then there'd be no need for en_US. lol
If you have chosen Belgian Dutch, and for some modules there is only a Netherlands Dutch available, you still get your translations displayed.
Well, there are different flavors (or is that flavours ) of english, just like there are multiple codes of French (fr-fr, fr-be) or Dutch (nl-be, nl-nl) or Portuguese (pt-br, pt-pt).
i propose, if we don't find the exact match, we look for the first part. If you have chosen Belgian Dutch, and for some modules there is only a Netherlands Dutch available, you still get your translations displayed. if nl-be returns a result, that's ok. If 'nl' returns a result, that's a good second choice.
Comments?
queens english is rarely spoken outside the upper class circles (if it is spoken then), and hardly ever used in written form unless you're doing your dissertations for university (which have to be in queens english). But queens english is more about Grammar than the spelling of words. there is no I in queens english.
so a sentence of 'I am going to the shop' in queens english would be 'One is going to go to the shop'
'you would think that' would be 'one would think that'.
One would think one should know how to spell.
but 99% of people in Britain use the British spellings regarding s & z. like colonise, digitise. but with a British accent & correct speaking, it actually sounds like colonISE (you can hear the S) it wouldn't sound like ize.
and spell colour not color, flavour not flavor, favourite not favorite.
Aluminium not Aluminum
There's the Queen's English and then there's a bunch of people who are just wrong :)
There is actually no single definitive standard for English. Even for UK English there are two major dictionaries considered to be authoritative, which differ on things like use of s vs z.
Re. the scripts, if you had an en-whatever language folder it would still work, no presumption is made about what languages are available on the system or what they are called, it will inspect every language subdirectory. It also does not care if any of the standard language file names are missing as not all are used in all modules. However, it will not touch any file with a non-standard name, and it does not attempt to work on Protector whose language files reside somewhere else.
if those bloody american's didn't keep changing the spelling of English words, removing letters or changing letters all the time, then there'd be no need for en_US. lol
#JustSayin