Interesting point, in a way we would use events to do some kind of observer pattern, am I correct?
Probably if we could fix our events system we could make modules do stuff that we trying todo with plugins. F.e. module that can use sitemap functionality could trigger some events that could be handled by sitemap module. If there are no such module, these events will be ignored.
I guess it's all good now :)
in all ImpressCMS versions until now, (1.4) we are basing ourselves on the file location to determine whether a folder contains a module, a theme, a translation or a plugin. Autoloading and composer have allowed us to look into changing that concept a bit.
With composer, it is perfectly possible to change from one library to a fork, while keeping the same development interface. All packages are bundled under the 'vendor' folder now, without indication what type of library they are.
In the case mentioned above, it could be that that fork is more actively maintained, or contains specific code that didn't make it into the main library. Moving to another maintainer of the library makes that the file location of your library will change under 'vendor'. Fortunately, autoloader takes care of the discovery aspect for you : you just tell it that you need class X, and the autoloader matches that with the file that needs to be loaded to make class X available, without you needing to knpw the name of the file on beforehand.
If we take the same concept and apply it to modules, themes and plugins, ImpressCMS still looks in specific locations for certain addon types. we look for modules by reading the icms_info.php files in the subfolders of the 'modules' folder, we look for themes by checking if there is a theme.html in te subfolders of 'themes', and so on for translations and editors.
One place where this is problematic, is with plugins. For example, the sitemap module has plugins for a long list of external modules, to help it understand the content of those other modules, and construct a correct sitemap from them. At the moment, those plugins are bundled with the sitemap module, and they are stored in a subfolder of the sitemap module folder.
That poses a problem if we want to add a plugin for the sitemap module from another module without resorting to copying files from one location to another, or having specific 'registration' routines. Here, the PHP Reflection API comes to our rescue. It allows us to scan all the classes in the system, and identify the class interconnexions. Which class is a subclass of ipf_module, for example, and which class is a subclass of ipf_module_sitemap. Have a look at StackOverflow for an example.
Perhaps this is worth looking into for future versions, to make management of the different addons and other packages easier and decoupled from the file system.
Easter holidays, so work has been a bit more slow. I did manage to finish the German translation in transifex this evening, I'll upload a complete translation pack tomorrow.
I did start to rework my solution to plugin to the composer library, but I got lost in the complexity of what I'm trying to get. I think I'm aiming too high, certainly for a first version Work continues on that, because it is one of the remaining new funtionalities that needs to go in before we can start looking into producing beta versions of the 2.0 branch - feature complete, but perhaps more bugfixing needed. My new approach is to let the design patterns on the side for the moment, and just get something working first. We can refactor the hell out of it afterwards.
Because nobody understood why we work in the 'retro' branch, and because those reasons date way back, Mekdrop has taken on the task of migrating our working branch for ImpressCMS 2.0 to the 'master' branch.
I've installed the Chromium-based Edge browser on my machine, and it works like a charm. I know people will look at me sideways when I say that I didn't have any problem with the Edge that was included in Windows 10, I'm generally not such a plugin user so their initial lack didn't pose a problem to me. The chromium-based Edge feels faster and more responsive, and it remains very much Edge. The fact that there's a Google-sponsored Chromium engine underneath hasn't changed that much.
I mention this because I tested our site (of course) with Chromium Edge, and noticed that Edge now also suffers from ticket #100 in ImpressCMS 1.3. Time to get that sorted out.
David L asked how he could test out or current state of ImpressCMS 2.0, and it turns out that the documentation for that is severely lacking and/or out-of-date. I've given him a short roadmap on how to get a ImpressCMS 2.0 alpha 7 site up and running on his shared hosting, but it's time I wrote some documentation.
I discovered this morning when I was on the train going to Brussels that my work on the composer integration was more or less useless because I was re-inventing the wheel. Composer has a class 'installer' that takes care of most things for me.
I'm looking into resurrecting the API documentation for 1.3 and 2.0, and I've looked into Fabien Potencier's SAMI to do so. I know, it's been discontinued, but I still have to find a tool that allows me to do a command-line crawl directly in my Github repository. I have some issues with git telling me that my repository is not clean in the 1.3 branches, so I'll need to do some spring cleaning before that can be published.
I'm starting this thread to give you an idea about what I'm currently working on, without needing to fire up another module or another external service to do so. No guarantees about the frequency though.
No guarantees about the content either, except that it will be ImpressCMS-related, but I might ot limit my contributions here to pure development aspects.
Hi @Eyekeeper, is there any place where we could check out your datatables integration? I would love to add it into the ImpressCMS 2.0 betas
yep,this is a test thread. Still nothing that went wrong. We'll have to see with some other user accounts perhaps.
I'm just testing the stuff to see if I can get another error that kicks in on the forums. I hope it doesn't, that will mean I've fixed the case for the version that we are using on the site.
Perhaps later we'll see into rewriting the forum module more thoroughly.
I tried some more fixes, because the error didn't seem to be resolved in all cases.
Visibly the fix wasn't working as I thought. It's a difficult fix because the problems isn't there the entire time
When you look at the error message, there is an error in the SQL because one of the keys in the object seems to give a totally nonexistent value. I tried to fix it now in the old Art framework, but I'm not sure if my fix is working ok. Let's test
Hi, I did some investigation to the errors we are experiencing from time to time on the forum, and I think they are now resolved.
I looked around, and stumbled upon this page : https://bitsofco.de/async-vs-defer/ where the author explains a bit what the different options are, and when you can use what.
In the end, lesser files to download, even if they are bigger, is also an optimization. So you could also consider using tools like webpack, to reduce the size and the number of files you include in your page as an extra optimisation.
This may be related to something I was just hashing over for page speed optimization. Google's Page Speed Insights suggests changing the parsing and execution of scripts and stylesheets and putting them only just before they are needed. Placing script tags and stylesheet tags in the header of a page actually stops page rendering until they are downloaded and parsed. See this info page from Google.
Anybody know of any reason NOT to defer their execution until the end of the page rendering?
Datatables integration would be great, so please do a PR for 2.0 once you have something that works
As you found out, that is limited to small datasets. Once you get into the few hundreds, the browser slows down considerably. The trick is to plugin PHP functionality to replace some of the functions that datatables does in the browser, and shift the workload as much as possible to the server. Sorting and such as well, because if you load only 15 elements inside of datatables, in its standard configuration, it will only work with those 15 lines, giving very funny results, that will be plain wrong
in my opinion, you will need to write an integration for the loading, updating, sorting, searching of data from datatables within ImpressCMS. Once you have that, the sky will be the limit
Hello! I'm trying to customize the standard icms_ipf_view_Table Actually, in order to use DataTable jquery Plugin I overwrote my system_persistabletable_display.html file in order to be able to use the plugin. (https://datatables.net/)
For small tables it works like a charm, but when you have slightly bigger ones (around 1k records), data is being fetched completely and then Datatable is redendered. The downside is that it becomes really slow untill all loading is completed.
I've also tried to keep the tree selector where I can have limits for 10, 15 etc records, but then I cannot access more data than selected for some reason. I have other, larger tables where I can see thing getting too slow then.
Reading the documentation I came up to defer loading, json rendering and background loading methods, but I don't know how to apply thoses changes inside impresscms in order to have it running.
Some links I read: https://datatables.net/examples/server_side/defer_loading.html http://datatables.net/release-datatables/extras/Scroller/large_js_source.html https://datatables.net/faqs/#speed Any thought on how to optimize this loading process?
Most front-end developers nowadays user LESS or SASS in their workflow, and they have grunt or node.js or gulp systems setup to compile, rework, minify and zip the resulting files into the most efficiënt package possible for web consumption. I think we should leave that part to the designers and front-end developers, because that changes so often and it's really different technology.
ImpressCMS doesn't handle included files well at the moment. If one day there would be a way to interactively define the different files to include through the core (on server or remote), it would start making sense to try to manage them in the core, but not before.
ImpressCMS 2.0 will come with composer out of box. So, installing PHP modules and libraries will be easier, but what about front-end assets? Do you have idea?
...so do you? Would you like to share your own opinion here -> https://github.com/ImpressCMS/impresscms/issues/134
Yeah, I know that this question is on GitHub, but I think this is a better place for talking about any development issues :)
Are you communicateing much between each other... during coding /development? ## I saw that Sato seems to relax after, was it 1.3.2 or somti'n. ## I think we now can keep climat more cool and planned around here now. When this template thing is solved, that is. ## Is there any discussion about roadmaps? /MG /JN /WN (since ~2007, I think). Happy and rising 2018!