Development Discussions

Re: new 2.0 release

I agree with the Google UA towards Google Analytics 4 migration need. In the current stage, we can easily work with preloads. The issue should be discussed further though.

Topic


Re: new 2.0 release

Perhaps we also include a warning in the admin panel for the upcoming deactivation of UA and instructions on how to switch their ImpressCMS site once they have made the switch with Google.

Topic


Re: new 2.0 release

I was also thinking this release should address Google Analytics 4 over Universal Analytics - UA will stop working/reporting in 4 months (July 1).

This is kind of tricky, since we can't determine if a site has been converted, or if the new GA4 property tag has been created. Going through this for myself, the ID is different, so both the code and the ID need to be updated for a site.

I see you have implemented this as a plugin on this site, @fiammybe, and removed the section cf the core code that inserts the ga snippet into every page. Maybe we do that for both options - create preload plugins and have the administrator activate the one they use. Assume they are using UA (since that is what the core is injecting) and move that to preloads with the upgrade. Provide an alternative for GA4.



Re: new 2.0 release

My list:

Required -

  • New install completes successfully on PHP 7+
  • Works without error at minimum version - PHP 7.x
  • Works (may have warnings) on PHP 8.x. PHP 8.0 at a minimum
  • Module updates work
  • Module installs work
  • Able to save preferences
  • Editors work
  • User registration, profile updates, group memberships work
  • Upgrade works from previous versions (will need clear steps for PHP version change)
  • Other prerequisites clearly defined for what needs to be changed in configuration and settings (using PDO, for example)

Recommended -

  • How to determine if your modules are compatible - and a list of modules we've tested

Things we can't verify -

  • If a site is using a custom block or custom tag with PHP content, we can't validate it will work on PHP 7+
  • The same is true of extra plugins and preloads not distributed with the core



Re: New designation for our old 2.0 branch

That sounds like a great OpenAI idea. Didn't they have a generator for this type of images? Show me my photo how i'd look like captain picard?

I'll have a look, sounds like a fun project.



Re: new 2.0 release

Of course, I forgot that valentine's day is more of less the black Friday for the flower business.

I will update the estimated date on the Github milestone.

Just to make sure, what are precisely the situations to test? Php 7.0 until php 8.0?

Upgrade from 1.4.4?



Re: A new milestone has been reached!

And that is just on GitHub. That doesn't count what was done on SourceForge and Assembla,



Re: new 2.0 release

I have limited time in the next few days for much of anything besides flowers. We are at a point to start the final testing and validation to move us on to the final release, though.



Re: New designation for our old 2.0 branch

Could also choose from the 3 characters of The Original Series that made appearances on TNG: Spock, McCoy, Scottie. Growing up, I thought Spock was the best.



Re: New designation for our old 2.0 branch

I guess the whole discussion will be : who wants to be Data?



new 2.0 release

Hi,

Valentine's day is coming around the corner, and although I don't see myself as a flying cupid that shoots arrows everywhere, it is a special day to perhaps latch onto for the 2.0 release.

When I look in Github for the new 2.0 milestone, there are still some things to be verified, next to the discussion about the csstidy ticket. I estimate we might be ready to release a quick RC on monday, just to get the scope finalised and do some more non-regression tests. And after that release on tuesday, just in time for Valentine's Day - Because we love our users so much

Would that be a reasonable (if short) timeline?



Re: A new milestone has been reached!

That is a momentous occasion! Thank you for putting this into the spotlight.

With the new 2.0 coming around the corner and also some movement in our newly-minted ImpressTNG branch, that number of PRs is certainly going to rise even more!



A new milestone has been reached!

Over the years, we have used different version control repositories, our current one being GitHub. A recent merge of a pull request has pushed us to 1,000 pull requests that have been merged into our core - https://github.com/ImpressCMS/impresscms/pulls

Thanks for all the efforts that have gone into bringing us this far!


Attach file:


png  impresscms-1000-github-prs-merged.png (27.52 KB)
54__1014063e7daba541ec.png 640X198 px


Re: New designation for our old 2.0 branch

I like it! Maybe we should all take on a character from the series and make that our avatar.



New designation for our old 2.0 branch

Hi, we arrived at the situation that our new branch number (2.0) was being overtaken by the needs of the legacy version. That is a common pitfall with long-winding releases, quite common actually.

The solution is to not give your next version a number, simple as that That way, your version number cannot be taken by the legacy codebase.

I'm a sci-fi aficionado (sometimes described as 'geek') so I would propose "ImpressTNG" as designation for our next major version. ImpressCMS - The Next Generation (cue Star Trek The Next Generation theme song). What do you think? Other proposals certainly welcome. Let's see what we can come up with



Re: Remove TinyMCE from the upcoming 1.5.0

I can understand the confusion : As a matter of fact, everything works with PHP 7.4, but I can't get it to install on PHP8 because that version is more strict on declaration of constants, and because my PHP8.0 debug setup is totally broken

So I may have accidentally already pushed the 'final' label and got confronted with the PHP8.0 issues after that.

So, no problem to add it still to 1.5.0.



Re: Remove TinyMCE from the upcoming 1.5.0

I see 1.5.0 is still described as Beta in include/version.php, though it's status is set to Final. Last release on GitHub was 1.5.0 RC.

I submitted a pull request for these tests and removal of the folders during an upgrade if appropriate. Warnings show if either editor is present and another warning if they are set as the default editor for any module or the core.



Re: Remove TinyMCE from the upcoming 1.5.0

I'll pull this together for 1.5.1, or can we still add to 1.5.0?



Re: Remove TinyMCE from the upcoming 1.5.0

Should we wedge this in and apply the same methodology for TinyMCE?

Absolutely agree.



Re: Remove TinyMCE from the upcoming 1.5.0

I was looking at this and discovered the work we did on removing FCKeditor is not in the core. We had intended that to be in the 1.4.4 release.

https://github.com/ImpressCMS/impresscms/pull/833

It might have gotten missed - somehow I was working in your repository - https://github.com/fiammybe/impresscms/tree/branches/1.4_fckeditor_warning

Should we wedge this in and apply the same methodology for TinyMCE?




 Top