Fork me on GitHub

update 8 june 2019

I've had some interference by Life (tm) recently : either it was scorching hot, which didn't really tempt me to sit in front of a computer and sweat just because of the temperature, either we were having heat thunderstorms, and I was battling a leak in our roof. all of those aren't conductive to development sadly

That period seems to be over now (the leak is fixed, and the sun seems to be burning elsewhere), so now I can start finishing the 1.4 release.

ImpressCMS 1.4

As a matter of fact, the only thing that still needs to be done (and that is holding up that release of course) is the update procedure. The 1.4 release removes the banners functionality in the core, and replaces it with the banners module. That is a migration script that needs to be tested.

We're celebrating Pentecost tomorrow, and that means that we have a holiday on monday. Normally, I should have the 1.4.0 beta release out by monday evening to test the migration routine.

ImpressCMS 2

Not much progress on the composer integration until now. I really want to get this up and running, but composer is not easy to understand nor to debug.

Topic | Forum


Re: some miss?

No problem. I think I'll have to update the documentation on how to create a ticket on github, that will be a good opportunity.

Topic | Forum


Re: some miss?

Sorry, I don't understand  how to use github

 



Re: Forum bugfix

Thank you for the confirmation! As it happens more with bugs that don't appear al the time to everybody, it was difficult to find out where the issue was, and during the iterations where we tried to fix the bug, we weren't 100% sure that it was well and truly squashed.

Given that you consistently had the problem, and you confirm now that it no longer affects you, I'm more confident that the bug is gone.



Re: Defining modules and plugins in a composer world

yeah... probably that is so called.



Re: Defining modules and plugins in a composer world

Interesting point, in a way we would use events to do some kind of observer pattern, am I correct?



Re: Defining modules and plugins in a composer world

Probably if we could fix our events system we could make modules do stuff that we trying todo with plugins. F.e. module that can use sitemap functionality could trigger some events that could be handled by sitemap module. If there are no such module, these events will be ignored.



Re: some miss?

Hi, 

I made 2 pull requests for these changes : 

Thank you for the info! Do not hesitate to make a github account and propose changes like this yourself diretly via Pull Request.



Re: Improve your SEO knowledge with Woorank

  • 2019/5/22 23:31:00
  • vipul

seo is important for online marketing. seo is the process of keep changing the position of web site  on search engine .



Re: Forum bugfix

I guess it's all good now :)



Re: some miss?

Hello,

those are locations that cannot be visited directly. Can you explain what page you visited and what action you made when you received the error?

Thank you for the feedback!

Kind regards,

David



some miss?

libraries/icms/object.php

in switch 

forexample

                       if ($v['required'] && $cleanv != '0' && $cleanv == '') {
                            $this->setErrors(sprintf(_XOBJ_ERR_REQUIRED, $k));
                            continue;
                        }
and I had PHP error and I change continue to break.

libraries/icms/textsanitiaer.php

line 244

if($html=0) --> if($html==0) ???

libraries/icms/form/element.php

line 345

            return "if (myform.{$eltname}.value == \"\") { window.alert(\"{$eltmsg}\"); myform.{$eltname}.focus(); return false; }";
--->

 if($eltname)
           return "if (myform.{$eltname}.value == \"\") { window.alert(\"{$eltmsg}\"); myform.{$eltname}.focus(); return false; }";

???

plugins/preloads/autologin.php

line 52

$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('uname', $uname4sql));

-->

$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('login_name', $uname4sql));

???

Thanks



Re: A project I've been putting off - ICMS 1.2.x to 1.3.x

I'll have a look if I can find the migration script we had for the imblogging module, I think it could be useful for moving over the original news to the new news module by @madfish.

The permissions in the IPF modules until now have been handled exclusively in the 'groups' section of the system module, and there is no permissions handling done anymore in the module itself. That is a part that would be missing right now.



Defining modules and plugins in a composer world

in all ImpressCMS versions until now, (1.4) we are basing ourselves on the file location to determine whether a folder contains a module, a theme, a translation or a plugin. Autoloading and composer have allowed us to look into changing that concept a bit.

With composer, it is perfectly possible to change from one library to a fork, while keeping the same development interface. All packages are bundled under the 'vendor' folder now, without indication what type of library they are.

In the case mentioned above, it could be that that fork is more actively maintained, or contains specific code that didn't make it into the main library. Moving to another maintainer of the library makes that the file location of your library will change under 'vendor'. Fortunately, autoloader takes care of the discovery aspect for you : you just tell it that you need class X, and the autoloader matches that with the file that needs to be loaded to make class X available, without you needing to knpw the name of the file on beforehand.

If we take the same concept and apply it to modules, themes and plugins, ImpressCMS still looks in specific locations for certain addon types. we look for modules by reading the icms_info.php files in the subfolders of the 'modules' folder, we look for themes by checking if there is a theme.html in te subfolders of 'themes', and so on for translations and editors.

One place where this is problematic, is with plugins. For example, the sitemap module has plugins for a long list of external modules, to help it understand the content of those other modules, and construct a correct sitemap from them. At the moment, those plugins are bundled with the sitemap module, and they are stored in a subfolder of the sitemap module folder. 

That poses a problem if we want to add a plugin for the sitemap module from another module without resorting to copying files from one location to another, or having specific 'registration' routines. Here, the PHP Reflection API comes to our rescue. It allows us to scan all the classes in the system, and identify the class interconnexions. Which class is a subclass of ipf_module, for example, and which class is a subclass of ipf_module_sitemap. Have a look at StackOverflow for an example.

Perhaps this is worth looking into for future versions, to make management of the different addons and other packages easier and decoupled from the file system.



Re: MVC architecture, routers and other stuff

What I'm liking about the router + MVC-type approach is that far less code has to run to deliver a page. eg. my current modules have Ye Olde Traditional handler classes for each object, and these are huge because they hold the code to handle all actions for their client objects.

With the strict MVC approach these monolithic handlers are getting chopped up into smaller model classes, each of which only deals with a specific page view (one or two different actions, as opposed to everything), and the router selects which one to load. So there's a lot less stuff to read for any given page load.



Re: MVC architecture, routers and other stuff

Yes, specific routes that take their input from the symlinks that are already present, with the fallback to 'standard' module routes. That would be great to have.



Re: VS Code

I tried it on and off over a period of a year more or less, and I think I'm just too used to the way PHPStorm is working. I had a very hard time with the way VS Code handles its Git integration, and a few other things that I just didn't want to invest time in to figure it out

If PHPStorm isn't available though, VS Code would be my second choice in a heartbeat. The plugin system has a wealth of functionalities, something that has been on the backburner a bit in PHPStorm lately.



Re: MVC architecture, routers and other stuff

I have made some progress with 2.0 and routing -> https://github.com/MekDrop/impresscms/tree/use-league-router . However right now I haven't figure out how to register routes for modules. But I hope somehow I will solve this and than this functionality will come to icms.



VS Code

Just a short note to say if you haven't tried the VS Code editor yet, it's well worth the effort.

I have always used Netbeans up until recently. It's ok and does the job, but it has a few issues that never seem to get fixed like needing to force FTP transfers and popping up huge tooltips over the line I'm trying to work on. And the interface kind of hurts my eyes (well, being Java based you kind of expect that).

I don't like changing editors but I eventually got annoyed enough to give VS Code a go and wow is it good. It's not that it does anything new, it just gets so many of the little things right that you actually end up getting more work done, because you aren't fighting the editor.



Re: 2 languages at 100% on softaculous

Thank you for these translations, I think those will be used in a translation banner I'll setup soon. I'd like to see if it's feasible to make it detect the location and the language of the browser, and show the relevant banner text




 Top