[Trac Ticket #21] ACP Breadcrumbs in 1.3

After discussing with Phoenyx and his solution for a dirst fix for the lack of ACP breadcrumbs. We have concluded that this feature needs to be enhanced - and it needs to be done for 1.3 as the new ACP theme requires breadcrumbs to be working.

Here is the fix Phoenyx has come up with so far.

kernel/module.php


before the function is closed add


This will pass the breadcrumbs that the module declares - however - this does nothing if the adminmenu is not constructed with IPF, and as it stands the modules menus that are being constructed with IPF are only passing the current pagename - which is fine. However - all of the system pages are only passing the term "System" as the pagetitle, so my current approach is lacking any real depth.

I heartily believe that system pages should pass a legitimate pagetitle. so if you are in Version Checker - the pagetitle should be Version Checker and not just System.

Anyway - here is the constructor for the breadcrumbs I have assembled in the template.



Now as you can see - I am checking against the active directory being system - which is the only way I could think of to assure that the pagetitle was not always being displayed for system pages - the issue here is that modules make use of the system module for a lot of their config pages... which means that the breadcrumb is going to report false information regarding the actual steps taken to reach the current page from the ACP Index.

Solution: no idea - ideally <{$breadcrumb}> should automatically be generating an actual breadcrumb trail without having to <{if/else/fake}> it.

Thoughts?

I have opened a ticket for this issue. [t:852]

I thought of a breadcrumb class which we could introduce to handle that providing methods for adding a deeper level (e.g. Profile >> Audio >> Edit) instead of constructing the breadcrumb in the module itself every time. This might make sense, however it might also make no sense.

The other option would be to take this as a reason to clean all breadcrumbs created systemwise.

I like the idea of a single class that inspects the page and constructs the breadcrumb. Although - I am open for anything that actually works :)

Have a look at the xoopstree class - it is used by several modules when there is a hierarchy of content (category - subcategory - item). There is also a breadcrumb separator language constant already defined.

Xoopstree is there, but if you read the methods it offers, you'll notice it seems more suitable for News module category selector box, not for breadcrumbs.

Besides that, I wouldn't like breadcrumbs rendering to be hardcoded, that is, I don't like:

<{$breadcrumbs}>

This is the way some modules render their own breadcrumbs, forcing any designer to hack the module if the want the breadcrumbs HTML to be different. I'd prefer breadcrumbs rendering to be controlled by a template. That is, $breadcrumbs should be an array that we process in the theme, like this:

<{includeq file=$theme_name/breadcrumbs.html breadcrumbs=$breadcrumbs }>

Besides offering more control during breadcrumbs render, the template would be reusable. Maybe our site's information requires a bi-dimensional or three-dimensional classification system, who knows.

Don't forget: This is all about the backend (ACP). We're not talking about the frontend here.

We could also name it $acp_breadcrumb. There's no real difference in the code for that .

I do understand where he is coming from - being able to control the delimiters and styleing in the breadcrumbs would be nice.

At this point - I would be happy if it just worked :)

I will wait and complain about how it works later down the line. :lmao:

Quote:

Done properly, it would apply to all areas of the site, without having to duplicate code and adjust it for a variation.

This is related to ticket #21.

Is there any news/progress on this?

I've checked in the beta release, and the breadcrumbs are still having the same issues.

Anyone that can have a look into this?

Is this of any help?

For both ACP & Frontside? Lets try it out .. and make it so if good

I am not very familiar with 1.3 yet, but it looks like that is only assigned to icm_tpl and not admin_tpl. Yes?

This was in 1.2.x (class/icmsbreadcrumb.php)

I don't see the breadcrumb template inside any other template - it would need to be added, along with the assignment of the values.

If I read the discussion correctly (thanks skenow for pointing that out), Will and Phoenyx would like the breadcrumbs to be automatic. Nachenko would like to pass an array to the breadcrumb class, as that would be more flexible.

If that is the case, these are two opposing things. We'll need to agree on a solution, and then implement it.

Skenow posted a proposal of a class. Would that class be a good start, or are there things that need to be added?

Bumping this one. I guess if no response is given to this, then the current implementation in the 1.3 beta is ok.

If not, let me know asap. :thumbup: