Reply New Topic
2013/8/18 15:16:47
#1
Offline
Webmaster

Please test ImpressCMS 1.3.5 RC2 packages

Hi everyone,
I just created the files for the release of ImpressCMS 1.3.5 RC2. Please have a quick look and test. If I don't get any negative notifications by tomorrow (well, that's more or less 14h from now), I'll publish the packages and the news.

these packages now include RC versions of content and profile, to include the improvements that have been made.

ZIP package
TAR.GZ package

Thanks!

_________________

Me on OpenHub


2013/8/19 7:15:44
#2
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Thanks for whole work, David. Tested around the fixes in core and modules. Seems to be much better now. This will be a very nice update


2013/8/19 14:20:25
#3
Offline
Webmaster

Re: Please test ImpressCMS 1.3.5 RC2 packages

thanks qm-b. I'm uploading the packages at the moment.

_________________

Me on OpenHub


2013/8/19 21:14:16
#4
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

I tested also, but incl the last 2 commits from the branch. And it's works as well for me with a fresh installation.

_________________
http://on.fb.me/x5lEdX

2013/8/20 4:42:30
#5
Offline
Webmaster

Re: Please test ImpressCMS 1.3.5 RC2 packages

@sato-san I came to the conclusion that the files that I created didn't include Steve's last 2 commits. I've added the changes into the RC2 branch now,
I'll create the files in the evening, and they will be uploaded immediately after that.

Sorry for the delay.

_________________

Me on OpenHub


2013/8/20 5:22:26
#6
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Thank you for the updated files @fiammybe - btw, I tested an update also and it looks good for me.

_________________
http://on.fb.me/x5lEdX

2013/8/20 11:15:46
#7
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

someone needs to keep a close eye on me - commit 12261 did not apply to 1.3 (though it does still work).

If it all works - we can tidy up for final.

Thanks, everyone.

_________________
Christian Web Resources
Facebook

2013/8/26 18:43:16
#8
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Hello, all - ready for the final?

_________________
Christian Web Resources
Facebook

2013/8/26 21:14:49
#9
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

I think too, we are ready

_________________
http://on.fb.me/x5lEdX

2013/8/26 23:34:47
#10
Offline
Webmaster

Re: Please test ImpressCMS 1.3.5 RC2 packages

We received a mail from the xps project that some copyright info is still missing. I'd like to check that prior to releasing a final. Final was scheduled for release on the 31st anyhow. My verifications will be done before that.

_________________

Me on OpenHub


2013/8/27 4:04:23
#11
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Tested again and think, we can go final now. Well, the copyright thing can be done before.


2013/8/28 16:44:30
#12
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Please commit the latest files to 1.3.6,since we have codefreez. We waiting for the final version soon.

_________________
http://on.fb.me/x5lEdX

2013/8/29 19:11:32
#13
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Anyone can hear my? :)

_________________
http://on.fb.me/x5lEdX

2013/8/29 19:19:22
#14
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

The release of 1.3.5 final will not be delayed by the changes to the documentation headers for copyright information, nor will it require another RC release. We have addressed this in the past.

We are still on track to release the final this weekend, along with an updated 1.2.8 (Smarty update for security).

_________________
Christian Web Resources
Facebook

2013/9/2 18:40:16
#15
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

I tested the last final pack and I think we have an issue in the search result page. If you enter a keyword who is not available, you get a redirect to search page, but no information that the page could not find anything. This is very confuse for the user

_________________
http://on.fb.me/x5lEdX

2013/9/3 1:41:15
#16
Offline
Webmaster

Re: Please test ImpressCMS 1.3.5 RC2 packages

Hi René,

is that different in 1.3.4?

_________________

Me on OpenHub


2013/9/3 13:32:24
#17
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

In previous versions, there was no message if no search results were found in any module - just the search form. I agree it isn't the best user experience and should be addressed, but that wasn't the purpose of the 1.3.5 release.

Now, I do see an error in the changes made to the search in regards to modules with no results - the logic is backwards in the current packages. This needs to be fixed before we release - 1 simple ! will take care of this.

In testing to confirm this, I have discovered that if no module has any results, the page is just as Rene describes it above - no message, no modules shown with 0 results - just the form. Basically, the option to display modules with no search results only works if at least 1 module has a result. I haven't found the fix for this, yet.

_________________
Christian Web Resources
Facebook

2013/9/4 3:12:40
#18
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Isn't this just a template change? currently it checks at the beginning for search results:
<{if $basic_search == false && $search_results }>

so we could simply add an else or elseif.. or removing the $search_results, if the searched module should be displayed without results


2013/9/4 21:21:15
#19
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

The unwanted insertion of line breaks into legacy content is still an issue, have posted a ticket (see this post for explanation).


2013/9/5 18:39:59
#20
Offline
Home away from home

Re: Please test ImpressCMS 1.3.5 RC2 packages

Quote:


QM-B wrote:
Isn't this just a template change? currently it checks at the beginning for search results:


<{if $basic_search == false && $search_results }>

so we could simply add an else or elseif.. or removing the $search_results, if the searched module should be displayed without results


I did find the fix for the various settings of 'show modules with no matches' and displaying - changed the nested if statements to a single 1 to get the proper hierarchy.

@qm-b: that could be a possibility for the time when there no modules return any results. $basic_search tells the page there was not a query - just go to advanced search form. $search_results is an array of results from all the modules queried, so it will only be false/empty when there are no results, at all.

At the end of the template, between the last

<{/if}>
<{$search_form}>


add another test for $search_results being empty, then display a language constant, like this, and style appropriately (completely untested, at the moment) -

<{/if}>
<{if count($search_results) = 0 }>
<div><{$smarty.const._SR_NOMATCH}></div>
<{$search_form}>

_________________
Christian Web Resources
Facebook

Reply New Topic extras
 Previous Topic   Next Topic
You can view topic.
You can start a new topic.
You can reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You can post without approval.