some miss?

libraries/icms/object.php

in switch 

forexample

                       if ($v['required'] && $cleanv != '0' && $cleanv == '') {
                            $this->setErrors(sprintf(_XOBJ_ERR_REQUIRED, $k));
                            continue;
                        }
and I had PHP error and I change continue to break.

libraries/icms/textsanitiaer.php

line 244

if($html=0) --> if($html==0) ???

libraries/icms/form/element.php

line 345

            return "if (myform.{$eltname}.value == \"\") { window.alert(\"{$eltmsg}\"); myform.{$eltname}.focus(); return false; }";
--->

 if($eltname)
           return "if (myform.{$eltname}.value == \"\") { window.alert(\"{$eltmsg}\"); myform.{$eltname}.focus(); return false; }";

???

plugins/preloads/autologin.php

line 52

$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('uname', $uname4sql));

-->

$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('login_name', $uname4sql));

???

Thanks

Hello,

those are locations that cannot be visited directly. Can you explain what page you visited and what action you made when you received the error?

Thank you for the feedback!

Kind regards,

David

Hi, 

I made 2 pull requests for these changes : 

• https://github.com/ImpressCMS/impresscms/pull/451
• https://github.com/ImpressCMS/impresscms/pull/452

Thank you for the info! Do not hesitate to make a github account and propose changes like this yourself diretly via Pull Request.

Sorry, I don't understand  how to use github

No problem. I think I'll have to update the documentation on how to create a ticket on github, that will be a good opportunity.