Reply New Topic
2008/12/31 2:26:51
#1
Offline
Home away from home

Error in contact module on 1.1.1 Final

Hi friends

Some users report me a problem if they use the contact module 1.5 and 1.6 - the module comes from xps, on impresscms 1.1.1 Final, it works without any problem on 1.1 Final.

The errors at the installations and or if you did make a upgrade and calling the module is:

Contact 1.6
Call to a member function icms_sessionOpen() on a non-object in footer.php on line 26

Contact 1.5
Call to a member function icms_sessionOpen() on a non-object in footer.php on line 23

The two errors in the header.php - but i will wait if the other users will confirm this, i see it only one time.

Andy suggestion for us friends?

Greetings Andy


2008/12/31 2:57:43
#2
Offline
Quite a regular

Re: Error in contact module on 1.1.1 Final

I have Contact 1.6. After upgrade from 1.1.1 rc2 to ICMS 1.1.1 final only blank page and this errors:
Poznamka: Undefined variable: xoopsConfig in file /header.php line 24
Poznamka: Undefined variable: xoopsConfig in file /header.php line 24
Poznamka: Undefined variable: sess_handler in file /footer.php line 26


2008/12/31 4:10:54
#3
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Thats the error warnings i can confirm in the header.php too!

Andy


2009/1/1 8:28:59
#4
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Really, a big problem with all contact/form modules.

- contact 1.6 works not (send no emails)
- contact 1.0 in the SVN sends a many SPAM
- liaise works not 100%
- formmail is ok, but use not impress-captcha and english language files not complete.
- formulize (i can not understand to create a form)
- formulaire (@philou has not finished the work)

please dev's, check for a solution. My personal favorite = formmail.

Thanks in advance!

_________________
http://on.fb.me/x5lEdX

2009/1/1 9:18:26
#5
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Alot of standard modules that we as site builders use everyday have been orphaned. The dev of impress has moved so fast (which btw is a wonderful thing!) that we can no longer do the simple stuff that is required to build a basic site.

I would like to see impress ship with basic modules like contact, sitemap and others or just build it into the core.

One of the main reasons I still use this system is because it was so easy to use out of the box many many years ago. You install then install a few modules bam your up and running.

The core shipped with standard modules to get things done fast that always worked. Its really the small stuff that adds up to be a great system. We need a basic pack of modules that can be download with or beside the core package.

Guys could we fix all the small stuff?

Let all the basic's of building a impress site catch up with what we have now. It's hard to even send a simple mail.


2009/1/2 11:47:14
#6
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

fix for footer.php

find

if(isset($_SESSION['sess_regen']) && $_SESSION['sess_regen']) { $sess_handler = & xoops_gethandler('session'); $sess_handler->icms_sessionOpen(true); $_SESSION['sess_regen'] = false; } else {$sess_handler->icms_sessionOpen();}


replace with

$sess_handler = & xoops_gethandler('session'); if(isset($_SESSION['sess_regen']) && $_SESSION['sess_regen']) { $sess_handler->icms_sessionOpen(true); $_SESSION['sess_regen'] = false; } else {$sess_handler->icms_sessionOpen();}


save and close.

header.php

find >

$xoopsLogger->startTime('ICMS output init');


add right after:

global $xoopsConfig;


save & close

_________________
Live as if you were to die tomorrow, Learn as if you were to live forever

The beauty of a living thing is not the atoms that go into it, but the way those atoms are put together!

2009/1/2 13:27:24
#7
Offline
Quite a regular

Re: Error in contact module on 1.1.1 Final

Thanks, works.

And small fix for footer.php. Find this code:

if(isset($_SESSION['sess_regen']) && $_SESSION['sess_regen']) { $sess_handler->icms_sessionOpen(true); $_SESSION['sess_regen'] = false; } else {$sess_handler->icms_sessionOpen();}


2009/1/3 4:19:28
#8
Offline
Not too shy to talk

Re: Error in contact module on 1.1.1 Final

thank you for fixing the bug. now still a bug fix for the ExtGallery 1.0.5 Module and many impresscms users are happy.

_________________
online shop | ImpressCMS Blog

2009/1/4 1:25:23
#9
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Will the fixed contact module (1.6) be added within the addons?
I really miss fixed/adjusted modules within this ICMS.org arrea.

_________________
Environment:
PHP Version 5.2.4
SQL: 5.0.77
Zend: v2.2.0
Apache: 1.3.39

2009/1/4 3:22:54
#10
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Can someone confirm the author of the Contact module?

As with exp-gal - I think we could add a modified version, but we should include the unmodified files also in the download.


2009/1/4 9:45:55
#11
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

the fixes i posted here, were made in the core of icms 1.1.1 and not the contact module. i didn't touch the contact module at all.

Quote:


Will the fixed contact module (1.6) be added within the addons?
I really miss fixed/adjusted modules within this ICMS.org area.



what other bugs is there?

_________________
Live as if you were to die tomorrow, Learn as if you were to live forever

The beauty of a living thing is not the atoms that go into it, but the way those atoms are put together!

2009/1/4 11:09:41
#12
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Hello all

A reply from the german community and me, the fixes works and the problems with the follwing modules and versions under 1.1.1 are gone:

- contact 1.5
- contact 1.6
- liaise 1.2.6
- liaise 1.2.7
- formulaire 3.4rc (there is another problem that stay not in touch with the fixes)

Thank you very much for your fast support!!!

Andy


2009/1/4 11:42:06
#13
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Contact 1.0 is one of the original modules that shipped with xoops. Over the years people added to it. The last release that I know of was called 1.6. Which was done by http://www.ibdeeming.com I cannot remember the guys name any longer. I do remember that he was very helpful on the boards at xo.

His 1.6 version has been my defacto standard for years and I love this little mod.

Anywho if you don't have a copy which is very unlikely here it is attached.

Edit:
No more attache permissions? lol


2009/1/4 11:44:40
#14
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

We've removed attatchment permissions until iForum is ready for release...


2009/1/4 11:47:21
#15
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final



2009/1/4 11:49:09
#16
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

Credits:

$modversion['credits'] = "Original version by Skalpa\nAAINC ([email protected]! User) for mod on From Email Name\n";
$modversion['author'] = "Modified by CreepingDeath - [email protected]!\nFrench Translation : Satanas - www.tech-at.be";


2009/1/13 13:57:46
#17
Offline
Just can not stay away

Re: Error in contact module on 1.1.1 Final

Quote:


sato-san wrote:

- formulize (i can not understand to create a form)



Hello, maybe this is not what you mean, but if you install the Formulize module, and then go to the admin side of the module, click the icon beside where it says "Create a form", then you will be able to type the name of the form, choose how many entries are allowed in the form, and then you will be able to add the elements to the form.

I know that a German translation is in the works, that would obviously help.

--Julian

_________________
Technical Architect - Freeform Solutions
Formulize - ad hoc forms and reports for ImpressCMS

2009/1/14 10:50:37
#18
Offline
Quite a regular

Re: Error in contact module on 1.1.1 Final

The patch worked well, however, I think it may bring up a point worth discussing.

Do we have a plan to maintain a "roll up" patch process for a frozen release version?

For example, if this patch might be considered appropriate for all ImpressCMS users on 1.1.1, should there be a place where we can get an updated patch containing all appropriate patches which could be applied to both an existing and new installation?

Best,

Alan


2009/1/14 11:38:31
#19
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

@Commerce my sentiments exactly.


2009/1/16 9:21:07
#20
Offline
Home away from home

Re: Error in contact module on 1.1.1 Final

here's a package containing the latest fixes from the 1.1.2 branch.

it only contains the files that have changed since 1.1.1 Final. (HTMLPurifier library is included in it's entirety though because for some reason the 1.1.1 Final release was shipped with an older version)

download from here

there maybe more changes once the 1.1.2 RC is released next week, but it is just a matter of uploading files, there aren't any Database changes, so update scripts aren't necessary :)

read the release_notes and changelog for more info.

_________________
Live as if you were to die tomorrow, Learn as if you were to live forever

The beauty of a living thing is not the atoms that go into it, but the way those atoms are put together!

Reply New Topic extras
 Previous Topic   Next Topic
You can view topic.
You can start a new topic.
You can reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You can post without approval.