Reply New Topic
2009/12/3 13:06:16
#1
Offline
Home away from home

Preparing RC 2

Hi everyone,

We got a little behind on our schedule regarding RC 2. We found some extremely annoying problems related to linebreaks and TinyMCE which absolutely needed to get fixed before release.

I believe we solve all the TinyMCE related problems now but I would really like a few people to test the latest trunk to see if we are right. Enable the TinyMCE editor and add some blocks. See if all works OK. Then do the same thing after switching back to the dhtml editor.

Let me know ! Thanks!!

_________________
Marc-André Lanciault
Founder and CEO INBOX International inc.
Co-Founder ImpressCMS

2009/12/3 13:13:25
#2
Offline
Home away from home

Re: Preparing RC 2

As already told in my eMail, I'll do some more testing based on the latest trunk tomorrow.

_________________
the german icms website : www.impresscms.de

2009/12/3 13:15:28
#3
Offline
Home away from home

Re: Preparing RC 2

Thanks Poenyx, appreciate it. Anyone else wants to help, you are more then welcome !!

_________________
Marc-André Lanciault
Founder and CEO INBOX International inc.
Co-Founder ImpressCMS

2009/12/3 13:48:20
#4
Offline
Home away from home

Re: Preparing RC 2

Testing the latest trunk:
1.- Create a block using TinyMCE: all fine.
2.- Set as default editor DHTML editor
3.- Modify the block using DHTML: I see
<p>text</p>. Fine

1.- Create a block using DHTML (as HTML block) there is not
<p> in paragraphs. All paragraphs has not <p> or <br> and all texts are in the same line.
But if I modified the block (autoformat), then <br> is added tipying Enter

Addind bbcode plugin in tinymce.php does not solved the problem (I tried it)


2009/12/3 13:57:54
#5
Offline
Home away from home

Re: Preparing RC 2

I tested exactly what you posted. Unless I'm missing something, everything works exactly as it should.

However, what do you mean by this:
[quote[But if I modified the block (autoformat), then <br> is added tipying Enter


If I edit the block I created with the dhtml editor with an HTML format, and then I change the format to auto format and I save it. Now I see the linebreak between the different test when the block is displayed. All is displayed correctly.

Let me know !

_________________
Marc-André Lanciault
Founder and CEO INBOX International inc.
Co-Founder ImpressCMS

2009/12/3 14:10:16
#6
Offline
Home away from home

Re: Preparing RC 2

As I understand your post (perhaps I get a mistake)
Just now I tried:
1.- DHTML as default edtor
2.- Create a block as HTML block: there is not <br>.
3.- But if I modified the block using DHTML as autoformat, there is not problem and <br> are added

For me: I can not create a HTML block using DHTML


2009/12/3 14:22:03
#7
Offline
Home away from home

Re: Preparing RC 2

The problem now seems about DHTML editor.
1.- Create a block (autoformat): fine
2.- Modifing it as HTML block: <br> is gone.


2009/12/3 19:01:22
#8
Offline
Home away from home

Re: Preparing RC 2

Here's what I have tried:

1. New install of trunk
2. Default editor = dhtmleditor; HTMLPurifier is enabled
3. Create a new block.
Content type = HTML
I typed the following into the content area

adding html using the dhtmleditor
<br>
<p>Here is a new paragraph</p>
<p>This is another paragraph, with a bulleted list
<ul><li>Item 1</li><li>item 2</></ul>
</p>


then I saved it. When I edited the block, the same content appeared. I could see the html tags as text, but that is to be expected.

4. Changed default editor to TinyMCE
5. Edited the new block and viewed the source (button on the tinymce toolbar). I was shown the following as the source for the block

<p>adding html using the dhtmleditor</p>
<p>Here is a new paragraph</p>
<p>This is another paragraph, with a bulleted list</p>
<ul>
<li>Item 1</li>
<li>item 2</li>
</ul>
<p>&nbsp;</p>


You'll notice the first line is wrapped in paragraph tags and there is an empty paragraph at the end, also the paragraph around the bulleted list is removed.

Without making any changes, I saved the block. When I edited the block a second time with TinyMCE as the default editor, the following was shown as the source


<p>adding html using the dhtmleditor</p>
<p>Here is a new paragraph</p>
<p>This is another paragraph, with a bulleted list</p>
<ul>
<li>Item 1</li>
<li>item 2</li>
</ul>


The first line is still wrapped in p tags, but the empty paragraph is gone.

This appears to be the desired behavior for both editors and for switching between them.

_________________

Steve Twitter: @skenow Facebook: Steve Kenow


2009/12/3 19:29:38
#9
Offline
Home away from home

Re: Preparing RC 2

So everything is working as expected, correct ?

_________________
Marc-André Lanciault
Founder and CEO INBOX International inc.
Co-Founder ImpressCMS

2009/12/3 19:48:00
#10
Offline
Home away from home

Re: Preparing RC 2

I would say so, yes.

_________________

Steve Twitter: @skenow Facebook: Steve Kenow


2009/12/4 2:55:23
#11
Offline
Home away from home

Re: Preparing RC 2

Yes; it is working.
Steve is right and I did an stupid error in my tests about making blocks using DHTML yesterday. (please, search a donkey gif for me ;)


2009/12/4 5:50:26
#12
Offline
Home away from home

Re: Preparing RC 2

working for me too :) many thanks to Arthur for figuring that out :)

_________________
Live as if you were to die tomorrow, Learn as if you were to live forever

The beauty of a living thing is not the atoms that go into it, but the way those atoms are put together!

2009/12/5 4:40:46
#13
Offline
Home away from home

Re: Preparing RC 2

Hi everyone,

I believe we are ready for 1.2 RC 2. Only 2 "major" and a few "minor": http://trac.impresscms.org/core/report/25

Minors will have to wait next release cycle. The 2 major, even though very annoying, have workarounds, so I recommend we address then in the next release cycle.

If there are no objections, I would like to start the release process.

_________________
Marc-André Lanciault
Founder and CEO INBOX International inc.
Co-Founder ImpressCMS

Reply New Topic extras
 Previous Topic   Next Topic
You can view topic.
You can start a new topic.
You can reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You can post without approval.