Reply New Topic
2009/12/3 12:10:17
#1
Offline
Home away from home

[Trac Ticket #21] ACP Breadcrumbs in 1.3

After discussing with Phoenyx and his solution for a dirst fix for the lack of ACP breadcrumbs. We have concluded that this feature needs to be enhanced - and it needs to be done for 1.3 as the new ACP theme requires breadcrumbs to be working.

Here is the fix Phoenyx has come up with so far.

kernel/module.php
function displayAdminMenu($currentoption = 0, $breadcrumb = '', $submenus = false, $currentsub = -1) [line 277]


before the function is closed add
global $icmsAdminTpl;
$icmsAdminTpl->assign('breadcrumb', $breadcrumb);


This will pass the breadcrumbs that the module declares - however - this does nothing if the adminmenu is not constructed with IPF, and as it stands the modules menus that are being constructed with IPF are only passing the current pagename - which is fine. However - all of the system pages are only passing the term "System" as the pagetitle, so my current approach is lacking any real depth.

I heartily believe that system pages should pass a legitimate pagetitle. so if you are in Version Checker - the pagetitle should be Version Checker and not just System.

Anyway - here is the constructor for the breadcrumbs I have assembled in the template.

<a href="<{$icms_url}>/admin.php">ACP Home</a> <span style="margin: 0px 4px;">></span> <{if $icms_dirname != 'system'}><a href="../"><{$icms_dirname}></a> <{if $breadcrumb != ''}><span style="margin: 0px 4px;">></span> <strong><{$breadcrumb}></strong><{/if}><{else}><strong><{$icms_pagetitle}><{/if}>


Now as you can see - I am checking against the active directory being system - which is the only way I could think of to assure that the pagetitle was not always being displayed for system pages - the issue here is that modules make use of the system module for a lot of their config pages... which means that the breadcrumb is going to report false information regarding the actual steps taken to reach the current page from the ACP Index.

Solution: no idea - ideally <{$breadcrumb}> should automatically be generating an actual breadcrumb trail without having to <{if/else/fake}> it.

Thoughts?

I have opened a ticket for this issue. [t:852]


Edited by UnderDog on 2011/3/3 5:24:12

Subject Poster Date
     [Trac Ticket #21] ACP Breadcrumbs in 1.3 Will 2009/12/3 12:10:17
       Re: ACP Breadcrumbs in 1.3 phoenyx 2009/12/3 13:12:13
         Re: ACP Breadcrumbs in 1.3 Will 2009/12/3 13:15:10
           Re: ACP Breadcrumbs in 1.3 skenow 2009/12/3 20:04:07
             Re: ACP Breadcrumbs in 1.3 nachenko 2009/12/4 0:36:32
               Re: ACP Breadcrumbs in 1.3 phoenyx 2009/12/4 11:29:25
                 Re: ACP Breadcrumbs in 1.3 Will 2009/12/4 11:32:42
                 Re: ACP Breadcrumbs in 1.3 skenow 2009/12/5 17:55:03
       Re: ACP Breadcrumbs in 1.3 fiammybe 2011/3/3 3:39:59
       Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 fiammybe 2011/3/21 13:41:52
         Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 skenow 2011/3/21 14:53:24
           Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 david 2011/3/22 1:56:21
       Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 Will 2011/3/22 4:43:23
         Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 skenow 2011/3/22 7:07:05
       Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 fiammybe 2011/3/24 12:45:08
       Re: [Trac Ticket #21] ACP Breadcrumbs in 1.3 fiammybe 2011/4/7 14:34:31
Reply New Topic extras
 Previous Topic   Next Topic
You can view topic.
You can start a new topic.
You can reply to posts.
You cannot edit your posts.
You cannot delete your posts.
You cannot add new polls.
You cannot vote in polls.
You cannot attach files to posts.
You can post without approval.