2007/12/10 1:57:22
|
---|
|
Re: ImpressCMS Themejames, looks great so far from the "view into source output". What I would add is a [html]label for the input(s).
after a quick look I ran into problems when the id of the single centercolums were assigned. eg, I never get a "single-top-center-column" though both left and right centerblocks were not set. This is because the values are overwritten some lines below. it is true that when both centerleft and centerright were empty normally this should be rendered as "single-top-center-column". but, ... some lines below there is <{elseif empty($xoops_clblocks) && !empty($xoops_ccblocks)}> which is in this explecit situaton also true so the id of the centerblock will be rendered as "wide-top-right-column" only. We can solve this situation copying the first block of lines (of the 3 blocks where the ids were assigned, not the blockoutput) below the 2 others (ctop centerblocks related) So we get this instead: <{if empty($xoops_ccblocks) && empty($xoops_crblocks)}> <{assign var='tclc' value='single-top-left-column'}> <{elseif empty($xoops_ccblocks) && !empty($xoops_crblocks)}> <{assign var='tclc' value='wide-top-left-column'}> <{assign var='tcrc' value='wide-top-right-column'}> <{elseif !empty($xoops_ccblocks) && empty($xoops_crblocks)}> <{assign var='tclc' value='wide-top-left-column'}> <{assign var='tccc' value='wide-top-center-column'}> <{else}> <{assign var='tclc' value='top-left-column'}> <{/if}> <{if empty($xoops_clblocks) && empty($xoops_ccblocks)}> <{assign var='tcrc' value='single-top-right-column'}> <{elseif empty($xoops_clblocks) && !empty($xoops_ccblocks)}> <{assign var='tcrc' value='wide-top-right-column'}> <{assign var='tccc' value='wide-top-center-column'}> <{elseif !empty($xoops_clblocks) && empty($xoops_ccblocks)}> <{assign var='tcrc' value='wide-top-right-column'}> <{assign var='tclc' value='wide-top-left-column'}> <{else}> <{assign var='tcrc' value='top-right-column'}> <{/if}> <{if empty($xoops_clblocks) && empty($xoops_crblocks)}> <{assign var='tccc' value='single-top-center-column'}> <{elseif empty($xoops_clblocks) && !empty($xoops_crblocks)}> <{assign var='tccc' value='wide-top-center-column'}> <{assign var='tcrc' value='wide-top-right-column'}> <{elseif !empty($xoops_clblocks) && empty($xoops_crblocks)}> <{assign var='tccc' value='wide-top-center-column'}> <{assign var='tclc' value='wide-top-left-column'}> <{else}> <{assign var='tccc' value='top-center-column'}> <{/if}> this works for me in this situation. Same counts for the bottom centerblocks. Or is it only me stupid? what i would like to see in the source were hr's to devide the sections more clearly. we may hide them or make the "not visible" but we may (a)buse them to clear (repair) some "module templates output errors" using clear:something. this for now! keep on good work my friend michael |